Add legacy data_access_point #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ilkilic
commented
Sep 15, 2023
ilkilic
commented
- add data_access_point for legacy purposes
- update example readme
- fix create_venv.sh
| * ``pipeline_settings`` contains settings used to configure the pipeline. There are many settings, that can each be important for the success of the model building procedure. The complete list of the settings available can be seen in the API documentation of the class `EModelPipelineSettings <../../bluepyemodel/emodel_pipeline/emodel_settings.py>`_. An important settings if you wish to run e-feature extraction through the pipeline is ``path_extract_config`` which points to the path of the json file containing the targets of the extraction process. | ||
| * ``params`` contains the essential mechanisms specifying their locations (e.g., axonal, somatic) as well as their distributions and parameters, which can be either frozen or free. | ||
| * ``features`` contains the path to the file that includes the output of the extraction, which are the ``efeatures`` and ``protocols``. The ``efeatures`` is a list of dictionaries, where each entry contains a feature associated with a specific protocol. ``protocols`` is also a list of dictionaries; each entry in this list contains the protocol's name, amplitude, among other details. | ||
| * ``pipeline_settings`` contains settings used to configure the pipeline. There are many settings, that can each be important for the success of the model building procedure. The complete list of the settings available can be seen in the API documentation of the class `EModelPipelineSettings <../../bluepyemodel/emodel_pipeline/emodel_settings.py>`_. An important settings if you wish to run e-feature extraction through the pipeline is ``path_extract_config`` which points to the path of the json file containing the targets, features names, protocols and files (ephys traces) of the extraction process. |
There was a problem hiding this comment.
typo: an important setting <- singular, not plural, so no 's'
| @@ -14,7 +14,7 @@ cd software | |||
| ../$VENV/bin/pip install wheel | |||
|
|
|||
| git clone https://github.com/BlueBrain/BluePyEModel.git | |||
| ../$VENV/bin/pip install -e ./bluepyemodel | |||
There was a problem hiding this comment.
You don't need to change that, I think
There was a problem hiding this comment.
when you clone it, the folder name has the uppercase letters
There was a problem hiding this comment.
oh yeah, you are right
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
- Coverage 61.65% 61.65% -0.01%
==========================================
Files 93 93
Lines 6231 6233 +2
==========================================
+ Hits 3842 3843 +1
- Misses 2389 2390 +1
☔ View full report in Codecov by Sentry. |
darshanmandge
approved these changes
Sep 15, 2023
AurelienJaquier
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.